Clean up error handling to have less unexpected errors #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecooper
requested review from
echo-bravo-yahoo,
mwilde345,
cleve-fauna and
henryfauna
echo-bravo-yahoo
approved these changes
Dec 13, 2024
Comment on lines
-38
to
+48
| // Schema push requires fsl locally...we need to accommodate for that, but for now, we'll just skip it | ||
| if (command === "schema push") { | ||
| return; | ||
| } | ||
| container.resolve("fetch").rejects(new TypeError("fetch failed")); | ||
| container.resolve("gatherFSL").resolves([ | ||
| { | ||
| name: "test.fsl", | ||
| content: "collection Test { name: String }", | ||
| }, | ||
| ]); |
There was a problem hiding this comment.
10/10, fun with DI testing
mwilde345
approved these changes
Dec 16, 2024
mwilde345
reviewed
Dec 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We have a few inconsistencies in error handling:
--secretSolution
This PR does a few things, but it most notably commits to using the errors defined in
errors.mjsin our lib code. Through adding new exceptions and common patterns to convert 3rd party errors to things we expect, we can get rid of most unexpected errors.AuthenticationErrorandAuthorizationError. The 401 case has a default message to remove the inconsistent ones we have already.xxxxToCommandErrorhelpers: Simplified the existingthrowForErrorfunction to just be a translation layer to catch the common error types across our dependencies.Result
Authentication errors and 4XX errors display consistently across the account, v4, v10, and schema APIs.
Testing
Add unit tests for the error mappings. Updated existing error tests.